]> git.baikalelectronics.ru Git - kernel.git/commitdiff
watch_queue: Make comment about setting ->defunct more accurate
authorDavid Howells <dhowells@redhat.com>
Fri, 11 Mar 2022 13:24:47 +0000 (13:24 +0000)
committerLinus Torvalds <torvalds@linux-foundation.org>
Fri, 11 Mar 2022 18:17:13 +0000 (10:17 -0800)
watch_queue_clear() has a comment stating that setting ->defunct to true
preventing new additions as well as preventing notifications.  Whilst
the latter is true, the first bit is superfluous since at the time this
function is called, the pipe cannot be accessed to add new event
sources.

Remove the "new additions" bit from the comment.

Fixes: c73be61cede5 ("pipe: Add general notification queue support")
Reported-by: Jann Horn <jannh@google.com>
Signed-off-by: David Howells <dhowells@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
kernel/watch_queue.c

index 37bcd900fd77d9025ea9b602a95a10f6c1aaa33f..00703444a21948deaa8b7ac8b57b73528badff0d 100644 (file)
@@ -566,7 +566,7 @@ void watch_queue_clear(struct watch_queue *wqueue)
        rcu_read_lock();
        spin_lock_bh(&wqueue->lock);
 
-       /* Prevent new additions and prevent notifications from happening */
+       /* Prevent new notifications from being stored. */
        wqueue->defunct = true;
 
        while (!hlist_empty(&wqueue->watches)) {