]> git.baikalelectronics.ru Git - kernel.git/commitdiff
EDAC: skx_common: downgrade message importance on missing PCI device
authorAristeu Rozanski <aris@redhat.com>
Wed, 4 Dec 2019 21:23:25 +0000 (16:23 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 5 Mar 2020 15:43:31 +0000 (16:43 +0100)
[ Upstream commit 128be2acd92549d0bf47aab3985c88016bf48a28 ]

Both skx_edac and i10nm_edac drivers are loaded based on the matching CPU being
available which leads the module to be automatically loaded in virtual machines
as well. That will fail due the missing PCI devices. In both drivers the first
function to make use of the PCI devices is skx_get_hi_lo() will simply print

EDAC skx: Can't get tolm/tohm

for each CPU core, which is noisy. This patch makes it a debug message.

Signed-off-by: Aristeu Rozanski <aris@redhat.com>
Signed-off-by: Tony Luck <tony.luck@intel.com>
Link: https://lore.kernel.org/r/20191204212325.c4k47p5hrnn3vpb5@redhat.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/edac/skx_common.c

index d8ff63d91b860ccedf3c6b930a002fc819fc6a45..a04349c6d17ef9c30d04ad6ce758c125486966a5 100644 (file)
@@ -235,7 +235,7 @@ int skx_get_hi_lo(unsigned int did, int off[], u64 *tolm, u64 *tohm)
 
        pdev = pci_get_device(PCI_VENDOR_ID_INTEL, did, NULL);
        if (!pdev) {
-               skx_printk(KERN_ERR, "Can't get tolm/tohm\n");
+               edac_dbg(2, "Can't get tolm/tohm\n");
                return -ENODEV;
        }