powerpc/cell/axon_msi: Fix refcount leak in setup_msi_msg_address

[ Upstream commit e2fa6acc8fa4eba4dbc82c32d3f3df445f6fde1b ]

of_get_next_parent() returns a node pointer with refcount incremented,
we should use of_node_put() on it when not need anymore.
Add missing of_node_put() in the error path to avoid refcount leak.

Fixes: 532ae9ce60f7 ("[CELL] add support for MSI on Axon-based Cell systems")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20220605065129.63906-1-linmq006@gmail.com
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/arch/powerpc/platforms/cell/axon_msi.c b/arch/powerpc/platforms/cell/axon_msi.c
index 57c4e0e86c8849a8f4a4f028ed16d17cd4c29717..ba33140e671dab57fe0b3f1ee6dc41c0639df02c 100644 (file)
--- a/arch/powerpc/platforms/cell/axon_msi.c
+++ b/arch/powerpc/platforms/cell/axon_msi.c
@@ -226,6 +226,7 @@ static int setup_msi_msg_address(struct pci_dev *dev, struct msi_msg *msg)
        if (!prop) {
                dev_dbg(&dev->dev,
                        "axon_msi: no msi-address-(32|64) properties found\n");
+               of_node_put(dn);
                return -ENOENT;
        }