]> git.baikalelectronics.ru Git - kernel.git/commitdiff
igb: Initialize mailbox message for VF reset
authorTony Nguyen <anthony.l.nguyen@intel.com>
Mon, 12 Dec 2022 19:00:31 +0000 (11:00 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 18 Jan 2023 10:40:48 +0000 (11:40 +0100)
commit 3fa081d77e5b5c202e26db1e94225a7c5896004d upstream.

When a MAC address is not assigned to the VF, that portion of the message
sent to the VF is not set. The memory, however, is allocated from the
stack meaning that information may be leaked to the VM. Initialize the
message buffer to 0 so that no information is passed to the VM in this
case.

Fixes: 84917a8c2ed8 ("igb: Indicate failure on vf reset for empty mac address")
Reported-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
Reviewed-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
Link: https://lore.kernel.org/r/20221212190031.3983342-1-anthony.l.nguyen@intel.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/ethernet/intel/igb/igb_main.c

index f718eadd87744ecf94836f99e5ac9cff4a505c93..37f174b41df31425cfa4ac9b5b14f92a571b502e 100644 (file)
@@ -7133,7 +7133,7 @@ static void igb_vf_reset_msg(struct igb_adapter *adapter, u32 vf)
 {
        struct e1000_hw *hw = &adapter->hw;
        unsigned char *vf_mac = adapter->vf_data[vf].vf_mac_addresses;
-       u32 reg, msgbuf[3];
+       u32 reg, msgbuf[3] = {};
        u8 *addr = (u8 *)(&msgbuf[1]);
 
        /* process all the same items cleared in a function level reset */