pstore/platform: fix potential mem leak if pstore_init_fs failed

[ Upstream commit 32827029a2fff2234609d049e4c2a1ddf32b978e ]

There is a potential mem leak when pstore_init_fs failed,
since the pstore compression maybe unlikey to initialized
successfully. We must clean up the allocation once this
unlikey issue happens.

Signed-off-by: chenqiwu <chenqiwu@xiaomi.com>
Link: https://lore.kernel.org/r/1581068800-13817-1-git-send-email-qiwuchen55@gmail.com
Signed-off-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/fs/pstore/platform.c b/fs/pstore/platform.c
index 3d7024662d29534147a5d5cb9bd78b82a4e22397..cdf5b8ae2583c91971a0807112994a61c4d54608 100644 (file)
--- a/fs/pstore/platform.c
+++ b/fs/pstore/platform.c
@@ -823,9 +823,9 @@ static int __init pstore_init(void)
 
        ret = pstore_init_fs();
        if (ret)
-               return ret;
+               free_buf_for_compression();
 
-       return 0;
+       return ret;
 }
 late_initcall(pstore_init);