net: ethernet: mtk_eth_soc: fix return value check in mtk_wed_add_hw()
authorYang Yingliang <yangyingliang@huawei.com>
Fri, 8 Apr 2022 03:22:46 +0000 (11:22 +0800)
committerDavid S. Miller <davem@davemloft.net>
Mon, 11 Apr 2022 09:45:34 +0000 (10:45 +0100)
If syscon_regmap_lookup_by_phandle() fails, it never return NULL pointer,
change the check to IS_ERR().

Fixes: 7e7e0fcc79f5 ("net: ethernet: mtk_eth_soc: add support for Wireless Ethernet Dispatch (WED)")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/mediatek/mtk_wed.c

index f0eacf819cd9cb2f024788d00a151b04b1c45ac4..5d510ac24f2a857c3456e88dca8e0c65dadcd49b 100644 (file)
@@ -813,7 +813,7 @@ void mtk_wed_add_hw(struct device_node *np, struct mtk_eth *eth,
                return;
 
        regs = syscon_regmap_lookup_by_phandle(np, NULL);
-       if (!regs)
+       if (IS_ERR(regs))
                return;
 
        rcu_assign_pointer(mtk_soc_wed_ops, &wed_ops);