clk: st: Fix memory leak in st_of_quadfs_setup()

[ Upstream commit bcc1aa64c8e662a3cea0c473975444af199cdfcf ]

If st_clk_register_quadfs_pll() fails, @lock should be freed before goto
@err_exit, otherwise will cause meory leak issue, fix it.

Signed-off-by: Xiu Jianfeng <xiujianfeng@huawei.com>
Link: https://lore.kernel.org/r/20221122133614.184910-1-xiujianfeng@huawei.com
Reviewed-by: Patrice Chotard <patrice.chotard@foss.st.com>
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/drivers/clk/st/clkgen-fsyn.c b/drivers/clk/st/clkgen-fsyn.c
index a156bd0c6af751f421e2e9bac15396cfaf980a7c..9eff05386ef9b1e94fa89e17a4dadd5c8478a8f4 100644 (file)
--- a/drivers/clk/st/clkgen-fsyn.c
+++ b/drivers/clk/st/clkgen-fsyn.c
@@ -943,9 +943,10 @@ static void __init st_of_quadfs_setup(struct device_node *np,
 
        clk = st_clk_register_quadfs_pll(pll_name, clk_parent_name, data,
                        reg, lock);
-       if (IS_ERR(clk))
+       if (IS_ERR(clk)) {
+               kfree(lock);
                goto err_exit;
-       else
+       } else
                pr_debug("%s: parent %s rate %u\n",
                        __clk_get_name(clk),
                        __clk_get_name(clk_get_parent(clk)),