leds: lt3593: Put fwnode in any case during ->probe()

[ Upstream commit 7e1baaaa2407a642ea19b58e214fab9a69cda1d7 ]

device_get_next_child_node() bumps a reference counting of a returned variable.
We have to balance it whenever we return to the caller.

Fixes: c23672c2dfce ("leds: lt3593: Add device tree probing glue")
Cc: Daniel Mack <daniel@zonque.org>
Signed-off-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/drivers/leds/leds-lt3593.c b/drivers/leds/leds-lt3593.c
index c94995f0daa2af5cffb16323f060867673b60f8f..03ae33093ce6354e20595e784a8f4154a91887ba 100644 (file)
--- a/drivers/leds/leds-lt3593.c
+++ b/drivers/leds/leds-lt3593.c
@@ -103,10 +103,9 @@ static int lt3593_led_probe(struct platform_device *pdev)
        init_data.default_label = ":";
 
        ret = devm_led_classdev_register_ext(dev, &led_data->cdev, &init_data);
-       if (ret < 0) {
-               fwnode_handle_put(child);
+       fwnode_handle_put(child);
+       if (ret < 0)
                return ret;
-       }
 
        led_data->cdev.dev->of_node = dev->of_node;
        platform_set_drvdata(pdev, led_data);