Revert "Input: atmel_mxt_ts - warn if sysfs could not be created"

Dmitry: I understand that I am a bit late to the party :) but I do not
agree with this change. Failure to create attributes is not sometihng
that user could cause (at least not easily) and thus would not be a
setup issue but something more severe. I believe we should fail
loading the driver so sysfs attribute breakage will be noticed as soon
as possible, instead of discovering it much much later in the process.

This reverts commit b4222c4697b85eb1755a63434dbf32d5b1b44a1e.

Requested-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: Henrik Rydberg <rydberg@euromail.se>

diff --git a/drivers/input/touchscreen/atmel_mxt_ts.c b/drivers/input/touchscreen/atmel_mxt_ts.c
index 37190ab1f81740e5c9dd660c364259a0d2a463ee..3ad942ca872546d6cc0dabf616acff1d687825d9 100644 (file)
--- a/drivers/input/touchscreen/atmel_mxt_ts.c
+++ b/drivers/input/touchscreen/atmel_mxt_ts.c
@@ -1184,10 +1184,13 @@ static int __devinit mxt_probe(struct i2c_client *client,
 
        error = sysfs_create_group(&client->dev.kobj, &mxt_attr_group);
        if (error)
-               dev_warn(&client->dev, "error creating sysfs entries.\n");
+               goto err_unregister_device;
 
        return 0;
 
+err_unregister_device:
+       input_unregister_device(input_dev);
+       input_dev = NULL;
 err_free_irq:
        free_irq(client->irq, data);
 err_free_object: