]> git.baikalelectronics.ru Git - kernel.git/commitdiff
scsi: pm8001: Fix command initialization in pm8001_chip_ssp_tm_req()
authorDamien Le Moal <damien.lemoal@opensource.wdc.com>
Sun, 20 Feb 2022 03:17:45 +0000 (12:17 +0900)
committerMartin K. Petersen <martin.petersen@oracle.com>
Wed, 23 Feb 2022 02:31:17 +0000 (21:31 -0500)
The ds_ads_m field of struct ssp_ini_tm_start_req has the type __le32.
Assigning a value to it should thus use cpu_to_le32(). This fixes the
sparse warning:

warning: incorrect type in assignment (different base types)
   expected restricted __le32 [addressable] [assigned] [usertype] ds_ads_m
   got int

Link: https://lore.kernel.org/r/20220220031810.738362-7-damien.lemoal@opensource.wdc.com
Fixes: d8bc927408e3 ("[SCSI] pm8001: add SAS/SATA HBA driver")
Reviewed-by: Jack Wang <jinpu.wang@ionos.com>
Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/pm8001/pm8001_hwi.c

index dab75b481618facfc5e6a824e4c9da5af8754a58..d80b48e0e41b924db8463e900a60b5c67e7de0c7 100644 (file)
@@ -4619,7 +4619,7 @@ int pm8001_chip_ssp_tm_req(struct pm8001_hba_info *pm8001_ha,
        memcpy(sspTMCmd.lun, task->ssp_task.LUN, 8);
        sspTMCmd.tag = cpu_to_le32(ccb->ccb_tag);
        if (pm8001_ha->chip_id != chip_8001)
-               sspTMCmd.ds_ads_m = 0x08;
+               sspTMCmd.ds_ads_m = cpu_to_le32(0x08);
        circularQ = &pm8001_ha->inbnd_q_tbl[0];
        ret = pm8001_mpi_build_cmd(pm8001_ha, circularQ, opc, &sspTMCmd,
                        sizeof(sspTMCmd), 0);