]> git.baikalelectronics.ru Git - kernel.git/commitdiff
Input: cm109 - remove needless check before usb_free_coherent()
authorXu Wang <vulab@iscas.ac.cn>
Tue, 7 Jul 2020 04:17:46 +0000 (21:17 -0700)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Tue, 7 Jul 2020 18:01:37 +0000 (11:01 -0700)
usb_free_coherent() is safe with NULL addr and this check is
not required.

Signed-off-by: Xu Wang <vulab@iscas.ac.cn>
Link: https://lore.kernel.org/r/20200707030905.3123-1-vulab@iscas.ac.cn
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/misc/cm109.c

index c09b9628ad34ad48eda34add704c64ce414e664e..e413801f04910b581f8238d149486d1f8be451d6 100644 (file)
@@ -663,12 +663,8 @@ static const struct usb_device_id cm109_usb_table[] = {
 static void cm109_usb_cleanup(struct cm109_dev *dev)
 {
        kfree(dev->ctl_req);
-       if (dev->ctl_data)
-               usb_free_coherent(dev->udev, USB_PKT_LEN,
-                                 dev->ctl_data, dev->ctl_dma);
-       if (dev->irq_data)
-               usb_free_coherent(dev->udev, USB_PKT_LEN,
-                                 dev->irq_data, dev->irq_dma);
+       usb_free_coherent(dev->udev, USB_PKT_LEN, dev->ctl_data, dev->ctl_dma);
+       usb_free_coherent(dev->udev, USB_PKT_LEN, dev->irq_data, dev->irq_dma);
 
        usb_free_urb(dev->urb_irq);     /* parameter validation in core/urb */
        usb_free_urb(dev->urb_ctl);     /* parameter validation in core/urb */