powerpc/xmon: Fix -Wswitch-unreachable warning in bpt_cmds

[ Upstream commit 651b0a948c4b0f214ea8660d0ab9c8df0ee65515 ]

When building with automatic stack variable initialization, GCC 12
complains about variables defined outside of switch case statements.
Move the variable into the case that uses it, which silences the warning:

arch/powerpc/xmon/xmon.c: In function ‘bpt_cmds’:
arch/powerpc/xmon/xmon.c:1529:13: warning: statement will never be executed [-Wswitch-unreachable]
 1529 |         int mode;
      |             ^~~~

Fixes: 048408c2bb24 ("powerpc/xmon: Fix compile error with PPC_8xx=y")
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/YySE6FHiOcbWWR+9@work
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/arch/powerpc/xmon/xmon.c b/arch/powerpc/xmon/xmon.c
index f51c882bf9023af3e8007c79fd4bbfee16b49a3e..e34d7809f6c9f03925c80d3d7a3da04d8cc8b115 100644 (file)
--- a/arch/powerpc/xmon/xmon.c
+++ b/arch/powerpc/xmon/xmon.c
@@ -1525,9 +1525,9 @@ bpt_cmds(void)
        cmd = inchar();
 
        switch (cmd) {
-       static const char badaddr[] = "Only kernel addresses are permitted for breakpoints\n";
-       int mode;
-       case 'd':       /* bd - hardware data breakpoint */
+       case 'd': {     /* bd - hardware data breakpoint */
+               static const char badaddr[] = "Only kernel addresses are permitted for breakpoints\n";
+               int mode;
                if (xmon_is_ro) {
                        printf(xmon_ro_msg);
                        break;
@@ -1560,6 +1560,7 @@ bpt_cmds(void)
 
                force_enable_xmon();
                break;
+       }
 
        case 'i':       /* bi - hardware instr breakpoint */
                if (xmon_is_ro) {