]> git.baikalelectronics.ru Git - kernel.git/commit
io_uring: add clarifying comment for io_cqring_ev_posted()
authorJens Axboe <axboe@kernel.dk>
Sat, 21 Aug 2021 13:21:19 +0000 (07:21 -0600)
committerJens Axboe <axboe@kernel.dk>
Mon, 23 Aug 2021 19:10:47 +0000 (13:10 -0600)
commitfff80e7cce25d2d2fb68b6f64b977cfd60f1078f
treec70ec332bf0fcb42169909bdeb113f797187ec25
parentdcaa33864cf8ae24f82d1a96c158124c1e3e48cd
io_uring: add clarifying comment for io_cqring_ev_posted()

We've previously had an issue where overflow flush unconditionally calls
io_cqring_ev_posted() even if it didn't flush any events to the ring,
causing wake and eventfd increment where no new events are available.
Some applications don't like that, see commit 8a9278b99b9a for details.

This came up in discussion for another patch recently, hence add a
comment detailing what the relationship between calling the events
posted helper and CQ ring entries is.

Link: https://lore.kernel.org/io-uring/77a44fce-c831-16a6-8e80-9aee77f496a2@kernel.dk/
Signed-off-by: Jens Axboe <axboe@kernel.dk>
fs/io_uring.c