]> git.baikalelectronics.ru Git - kernel.git/commit
media: staging: rkisp1: fix test of return value of media_entity_get_fwnode_pad
authorDafna Hirschfeld <dafna.hirschfeld@collabora.com>
Tue, 4 Feb 2020 21:44:45 +0000 (22:44 +0100)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Mon, 24 Feb 2020 16:37:58 +0000 (17:37 +0100)
commitffbd29e4727397f78a91a55acb5d3d25e0a7a9cb
treeddc6b99966c7d124f4bc8689778cc4b92ac906a9
parentefe163a69b82a17f7b151dbb96b754b3e1f92d6f
media: staging: rkisp1: fix test of return value of media_entity_get_fwnode_pad

media_entity_get_fwnode_pad returns negative value on error
and the pad numeber on success. Therefore change the error test
from 'if (ret)' to 'if (ret < 0)' .

Fixes: 8879e185670c ("media: staging: rkisp1: add Rockchip ISP1 base driver")
Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>
Acked-by: Helen Koike <helen.koike@collabora.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/staging/media/rkisp1/rkisp1-dev.c