]> git.baikalelectronics.ru Git - kernel.git/commit
i2c: highlander: add IRQ check
authorSergey Shtylyov <s.shtylyov@omp.ru>
Sun, 30 May 2021 19:13:45 +0000 (22:13 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 15 Sep 2021 07:47:32 +0000 (09:47 +0200)
commitffa8806d2084743ad30a6458b03ba3e15801d394
tree37e94fcec71ad62a79afe46ad29a4e2dda5d1b8c
parentf285124c43d2aaa09ea71ad451df9a1890551673
i2c: highlander: add IRQ check

[ Upstream commit f16a3bb69aa6baabf8f0aca982c8cf21e2a4f6bc ]

The driver is written as if platform_get_irq() returns 0 on errors (while
actually it returns a negative error code), blithely passing these error
codes to request_irq() (which takes *unsigned* IRQ #) -- which fails with
-EINVAL. Add the necessary error check to the pre-existing *if* statement
forcing the driver into the polling mode...

Fixes: e34a8d219f59 ("i2c: Renesas Highlander FPGA SMBus support")
Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
Signed-off-by: Wolfram Sang <wsa@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/i2c/busses/i2c-highlander.c