]> git.baikalelectronics.ru Git - kernel.git/commit
device_cgroup: fix RCU imbalance in error case
authorJann Horn <jannh@google.com>
Tue, 19 Mar 2019 01:36:59 +0000 (02:36 +0100)
committerTejun Heo <tj@kernel.org>
Tue, 19 Mar 2019 17:46:15 +0000 (10:46 -0700)
commitff883b9156247060c2283bf39e9f23c7fc66aa43
tree181570811ec1a929a32b9054f1f55ba7833dcecc
parente34ba0d7c8ee128a8a7cc0a1d0345206aeb6a4e5
device_cgroup: fix RCU imbalance in error case

When dev_exception_add() returns an error (due to a failed memory
allocation), make sure that we move the RCU preemption count back to where
it was before we were called. We dropped the RCU read lock inside the loop
body, so we can't just "break".

sparse complains about this, too:

$ make -s C=2 security/device_cgroup.o
./include/linux/rcupdate.h:647:9: warning: context imbalance in
'propagate_exception' - unexpected unlock

Fixes: 5faa2b5b3281 ("device_cgroup: simplify cgroup tree walk in propagate_exception()")
Cc: stable@vger.kernel.org
Signed-off-by: Jann Horn <jannh@google.com>
Acked-by: Michal Hocko <mhocko@suse.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
security/device_cgroup.c