]> git.baikalelectronics.ru Git - kernel.git/commit
nilfs2: fix incorrect masking of permission flags for symlinks
authorRyusuke Konishi <konishi.ryusuke@gmail.com>
Thu, 23 Jun 2022 08:54:01 +0000 (17:54 +0900)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 21 Jul 2022 18:59:18 +0000 (20:59 +0200)
commitff0940d829a1eb8f97b68d6d1bd45c4571233279
treec661f0b08d049699ec18f3eed094bdb11a14b020
parenta308ef1ba83517c0f2e6c21c27b1d67e27db3fa8
nilfs2: fix incorrect masking of permission flags for symlinks

commit ee8d7e9ebef5c9bc5720b7f0fb54ff403bb34b38 upstream.

The permission flags of newly created symlinks are wrongly dropped on
nilfs2 with the current umask value even though symlinks should have 777
(rwxrwxrwx) permissions:

 $ umask
 0022
 $ touch file && ln -s file symlink; ls -l file symlink
 -rw-r--r--. 1 root root 0 Jun 23 16:29 file
 lrwxr-xr-x. 1 root root 4 Jun 23 16:29 symlink -> file

This fixes the bug by inserting a missing check that excludes
symlinks.

Link: https://lkml.kernel.org/r/1655974441-5612-1-git-send-email-konishi.ryusuke@gmail.com
Signed-off-by: Ryusuke Konishi <konishi.ryusuke@gmail.com>
Reported-by: Tommy Pettersson <ptp@lysator.liu.se>
Reported-by: Ciprian Craciun <ciprian.craciun@gmail.com>
Tested-by: Ryusuke Konishi <konishi.ryusuke@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/nilfs2/nilfs.h