]> git.baikalelectronics.ru Git - kernel.git/commit
regulator: ab8500: Remove AB8505 USB regulator
authorStephan Gerhold <stephan@gerhold.net>
Wed, 6 Nov 2019 17:31:24 +0000 (18:31 +0100)
committerMark Brown <broonie@kernel.org>
Thu, 7 Nov 2019 13:09:58 +0000 (13:09 +0000)
commitfebc706e9e27f5685d4809e752d852e7569a6b80
tree179fdf0620d6c0f0f968091ec6f64cc5f411ba85
parent33ade16e1b51ad9813aecc3f4ae3b086c3f1c4f2
regulator: ab8500: Remove AB8505 USB regulator

The USB regulator was removed for AB8500 in
commit fa5134211ed7 ("regulator: ab8500: Remove USB regulator").
It was then added for AB8505 in
commit e29fe8a9f3c9 ("regulator: ab8500: add support for ab8505").

However, there was never an entry added for it in
ab8505_regulator_match. This causes all regulators after it
to be initialized with the wrong device tree data, eventually
leading to an out-of-bounds array read.

Given that it is not used anywhere in the kernel, it seems
likely that similar arguments against supporting it exist for
AB8505 (it is controlled by hardware).

Therefore, simply remove it like for AB8500 instead of adding
an entry in ab8505_regulator_match.

Fixes: e29fe8a9f3c9 ("regulator: ab8500: add support for ab8505")
Cc: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Stephan Gerhold <stephan@gerhold.net>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Link: https://lore.kernel.org/r/20191106173125.14496-1-stephan@gerhold.net
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/regulator/ab8500.c
include/linux/regulator/ab8500.h