]> git.baikalelectronics.ru Git - kernel.git/commit
scsi: mpt3sas: remove redundant wmb
authorSinan Kaya <okaya@codeaurora.org>
Fri, 7 Apr 2017 19:06:18 +0000 (15:06 -0400)
committerMartin K. Petersen <martin.petersen@oracle.com>
Mon, 24 Apr 2017 22:31:41 +0000 (18:31 -0400)
commitfe3b8e37f63bb84be023e4519669a5a70e3c4a22
treed4d12d01d5dd3ddac23834ba2f9649ac7c6e744d
parent65787a16e51287066c2a75819d59846f8278fb03
scsi: mpt3sas: remove redundant wmb

Due to relaxed ordering requirements on multiple architectures, drivers
are required to use wmb/rmb/mb combinations when they need to guarantee
observability between the memory and the HW.

The mpt3sas driver is already using wmb() for this purpose.  However, it
issues a writel following wmb(). writel() function on arm/arm64
arhictectures have an embedded wmb() call inside.

This results in unnecessary performance loss and code duplication.

writel already guarantees ordering for both cpu and bus. we don't need
additional wmb()

Signed-off-by: Sinan Kaya <okaya@codeaurora.org>
Acked-by: Sreekanth Reddy <sreekanth.reddy@broadcom.com>
Reviewed-by: Brian King <brking@linux.vnet.ibm.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/mpt3sas/mpt3sas_base.c