]> git.baikalelectronics.ru Git - kernel.git/commit
ktest.pl minconfig: Unset configs instead of just removing them
authorSteven Rostedt <rostedt@goodmis.org>
Fri, 2 Dec 2022 16:59:36 +0000 (11:59 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 18 Jan 2023 10:41:45 +0000 (11:41 +0100)
commitfe373a091a4a349917a799109f3b6c17a20958a2
tree3581e421b41c8765fc12cc8a5be9be1e280f17ef
parent050fed1e68f3ea5c6abe39b22ca08fb8c4b62744
ktest.pl minconfig: Unset configs instead of just removing them

commit ff2420cd9f94b7bf6aea0d20efbed2247b09f2fb upstream.

After a full run of a make_min_config test, I noticed there were a lot of
CONFIGs still enabled that really should not be. Looking at them, I
noticed they were all defined as "default y". The issue is that the test
simple removes the config and re-runs make oldconfig, which enables it
again because it is set to default 'y'. Instead, explicitly disable the
config with writing "# CONFIG_FOO is not set" to the file to keep it from
being set again.

With this change, one of my box's minconfigs went from 768 configs set,
down to 521 configs set.

Link: https://lkml.kernel.org/r/20221202115936.016fce23@gandalf.local.home
Cc: stable@vger.kernel.org
Fixes: 6a34f8a6f58b1 ("ktest: Added config_bisect test type")
Reviewed-by: John 'Warthog9' Hawley (VMware) <warthog9@eaglescrag.net>
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
tools/testing/ktest/ktest.pl