]> git.baikalelectronics.ru Git - kernel.git/commit
hwmon: (tmp421) fix rounding for negative values
authorPaul Fertser <fercerpav@gmail.com>
Fri, 24 Sep 2021 09:30:11 +0000 (12:30 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 6 Oct 2021 13:42:33 +0000 (15:42 +0200)
commitfe0926bff57037dbf52f79fdfaf8582712906535
tree3f5aa98cdfa4bdef1aee9d8e214bfec1395f6a5c
parent21099d4f73995e730cfd4c4898dc3778ddf0b2b1
hwmon: (tmp421) fix rounding for negative values

[ Upstream commit 724e8af85854c4d3401313b6dd7d79cf792d8990 ]

Old code produces -24999 for 0b1110011100000000 input in standard format due to
always rounding up rather than "away from zero".

Use the common macro for division, unify and simplify the conversion code along
the way.

Fixes: 49fec4ff7c2b ("hwmon: Add driver for Texas Instruments TMP421/422/423 sensor chips")
Signed-off-by: Paul Fertser <fercerpav@gmail.com>
Link: https://lore.kernel.org/r/20210924093011.26083-3-fercerpav@gmail.com
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/hwmon/tmp421.c