]> git.baikalelectronics.ru Git - kernel.git/commit
iwlwifi: dbg: don't abort if sending DBGC_SUSPEND_RESUME fails
authorLuca Coelho <luciano.coelho@intel.com>
Fri, 6 Mar 2020 13:16:25 +0000 (15:16 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 8 Apr 2020 07:08:45 +0000 (09:08 +0200)
commitfdf5e7d9664fa8822d1f69f5187bf5b11907780f
treec736aed78e6f5bc79ab23a83296d7394c175dbb7
parent2de6c123504b56daaddf424fd4579097939d6c96
iwlwifi: dbg: don't abort if sending DBGC_SUSPEND_RESUME fails

commit 4b0e9cc57f25ec6f6831b05b6f1a60a4cc98a391 upstream.

If the firmware is in a bad state or not initialized fully, sending
the DBGC_SUSPEND_RESUME command fails but we can still collect logs.

Instead of aborting the entire dump process, simply ignore the error.
By removing the last callpoint that was checking the return value, we
can also convert the function to return void.

Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
Fixes: 9b7b6caea0c5 ("iwlwifi: dbg: support debug recording suspend resume command")
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
Link: https://lore.kernel.org/r/iwlwifi.20200306151129.dcec37b2efd4.I8dcd190431d110a6a0e88095ce93591ccfb3d78d@changeid
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/wireless/intel/iwlwifi/fw/dbg.c
drivers/net/wireless/intel/iwlwifi/fw/dbg.h