]> git.baikalelectronics.ru Git - kernel.git/commit
f2fs: fix incorrect return value in f2fs_sanity_check_ckpt()
authorChao Yu <chao@kernel.org>
Thu, 28 Oct 2021 12:45:08 +0000 (20:45 +0800)
committerJaegeuk Kim <jaegeuk@kernel.org>
Fri, 29 Oct 2021 17:37:35 +0000 (10:37 -0700)
commitfd75585d1981a44aa88aed472b5101f26fe3a19c
treea2a56f2d33aaa0083129ee14da2c1a79689cfc9c
parent18bb074cd46be7128128c4b8d5f86b748568d0ab
f2fs: fix incorrect return value in f2fs_sanity_check_ckpt()

As Pavel Machek reported in [1]

This code looks quite confused: part of function returns 1 on
corruption, part returns -errno. The problem is not stable-specific.

[1] https://lkml.org/lkml/2021/9/19/207

Let's fix to make 'insane cp_payload case' to return 1 rater than
EFSCORRUPTED, so that return value can be kept consistent for all
error cases, it can avoid confusion of code logic.

Fixes: bedd0a6b6d05 ("f2fs: fix to do sanity check for sb/cp fields correctly")
Reported-by: Pavel Machek <pavel@denx.de>
Reviewed-by: Pavel Machek <pavel@denx.de>
Signed-off-by: Chao Yu <chao@kernel.org>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
fs/f2fs/super.c