]> git.baikalelectronics.ru Git - kernel.git/commit
rtc: ds1685: Fix bank switching to avoid endless loop
authorThomas Bogendoerfer <tsbogend@alpha.franken.de>
Thu, 10 Sep 2020 08:41:24 +0000 (10:41 +0200)
committerAlexandre Belloni <alexandre.belloni@bootlin.com>
Tue, 15 Sep 2020 09:24:29 +0000 (11:24 +0200)
commitfd6ebb1edc289c95841cc2a4632e531b801ce47d
treea862fffb5c534a599b01d224c2518fd13da18ba3
parentcfc12bb09bb4f4105f5a395ad8dae81a59c008c8
rtc: ds1685: Fix bank switching to avoid endless loop

ds1685_rtc_begin_data_access() tried to access an extended register before
enabling access to it by switching to bank 1. Depending on content in NVRAM
this could lead to an endless loop. While at it fix also switch back to
bank 0 in ds1685_rtc_end_data_access().

Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Acked-by: Joshua Kinard <kumba@gentoo.org>
Link: https://lore.kernel.org/r/20200910084124.138560-1-tsbogend@alpha.franken.de
drivers/rtc/rtc-ds1685.c