]> git.baikalelectronics.ru Git - kernel.git/commit
pwm: sl28cpld: fix getting driver data in pwm callbacks
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Thu, 3 Dec 2020 08:41:42 +0000 (09:41 +0100)
committerLinus Torvalds <torvalds@linux-foundation.org>
Thu, 3 Dec 2020 17:57:37 +0000 (09:57 -0800)
commitfcfefe4eb0e255af72bad5d6bf8c9caf337ff9cf
treefe543769ae6a1a21d84c78cd9dc635f79a8865a3
parent8e8ae274cd3251b84fd37fc588cb9609d302ceba
pwm: sl28cpld: fix getting driver data in pwm callbacks

Currently .get_state() and .apply() use dev_get_drvdata() on the struct
device related to the pwm chip.  This only works after .probe() called
platform_set_drvdata() which in this driver happens only after
pwmchip_add() and so comes possibly too late.

Instead of setting the driver data earlier use the traditional
container_of approach as this way the driver data is conceptually and
computational nearer.

Fixes: 698ff6913793 ("pwm: Add support for sl28cpld PWM controller")
Tested-by: Michael Walle <michael@walle.cc>
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/pwm/pwm-sl28cpld.c