]> git.baikalelectronics.ru Git - kernel.git/commit
ALSA: xen: ensure nul-terminated device name
authorArnd Bergmann <arnd@arndb.de>
Mon, 28 May 2018 15:59:57 +0000 (17:59 +0200)
committerTakashi Iwai <tiwai@suse.de>
Tue, 29 May 2018 06:27:54 +0000 (08:27 +0200)
commitfcdc12a9e58a0b72d602b58b064e5e58d4d0e1ce
treec4d0c2d39b5bde8aac4d0a48b216724589cfd048
parent3fa09d504fda0a107791ae9cba2d0c0017d52ec5
ALSA: xen: ensure nul-terminated device name

gcc-8 warns that pcm_instance->name is not necessarily terminated correctly
if the input is more than 80 characters long or lacks a termination byte
itself:

In function 'strncpy',
    inlined from 'cfg_device' at sound/xen/xen_snd_front_cfg.c:399:3,
    inlined from 'xen_snd_front_cfg_card' at sound/xen/xen_snd_front_cfg.c:509:9:
include/linux/string.h:254:9: error: '__builtin_strncpy' specified bound 80 equals destination size [-Werror=stringop-truncation]
  return __builtin_strncpy(p, q, size);

Using strlcpy() instead of strncpy() makes this a bit safer.

Fixes: 15ea98a66787 ("ALSA: xen-front: Read sound driver configuration from Xen store")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/xen/xen_snd_front_cfg.c