]> git.baikalelectronics.ru Git - kernel.git/commit
net/tls: Fix sk_psock refcnt leak when in tls_data_ready()
authorXiyu Yang <xiyuyang19@fudan.edu.cn>
Sat, 25 Apr 2020 13:10:23 +0000 (21:10 +0800)
committerDavid S. Miller <davem@davemloft.net>
Mon, 27 Apr 2020 18:22:38 +0000 (11:22 -0700)
commitfcd4a27fa57e0aa92d1cc7b7f8e3f805a3a21c1d
tree2da8358a87aa37f0b3b8ea2a7c65a0370c669063
parenta9d7dc6b281f1c3e4045be1dec9731b76150e34b
net/tls: Fix sk_psock refcnt leak when in tls_data_ready()

tls_data_ready() invokes sk_psock_get(), which returns a reference of
the specified sk_psock object to "psock" with increased refcnt.

When tls_data_ready() returns, local variable "psock" becomes invalid,
so the refcount should be decreased to keep refcount balanced.

The reference counting issue happens in one exception handling path of
tls_data_ready(). When "psock->ingress_msg" is empty but "psock" is not
NULL, the function forgets to decrease the refcnt increased by
sk_psock_get(), causing a refcnt leak.

Fix this issue by calling sk_psock_put() on all paths when "psock" is
not NULL.

Signed-off-by: Xiyu Yang <xiyuyang19@fudan.edu.cn>
Signed-off-by: Xin Tan <tanxin.ctf@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/tls/tls_sw.c