]> git.baikalelectronics.ru Git - kernel.git/commit
mmc: rtsx_usb_sdmmc: fix return value check of mmc_add_host()
authorYang Yingliang <yangyingliang@huawei.com>
Tue, 1 Nov 2022 06:30:20 +0000 (14:30 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 31 Dec 2022 12:32:24 +0000 (13:32 +0100)
commitfcc16f99714c2d8d525a92a56c94b07e4053cb30
tree8c8574c9d428795b142cb8180e3085d6081f5659
parent5a20759e6e46e274d31f81063b5e68b141b695b0
mmc: rtsx_usb_sdmmc: fix return value check of mmc_add_host()

[ Upstream commit 83f4dd90ef636ac50a3c54569eb91aee98c41aea ]

mmc_add_host() may return error, if we ignore its return value, the memory
that allocated in mmc_alloc_host() will be leaked and it will lead a kernel
crash because of deleting not added device in the remove path.

So fix this by checking the return value and calling mmc_free_host() in the
error path, besides, led_classdev_unregister() and pm_runtime_disable() also
need be called.

Fixes: 135a3d8da9e6 ("mmc: Add realtek USB sdmmc host driver")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Link: https://lore.kernel.org/r/20221101063023.1664968-7-yangyingliang@huawei.com
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/mmc/host/rtsx_usb_sdmmc.c