]> git.baikalelectronics.ru Git - kernel.git/commit
ALSA: aoa: i2sbus: fix possible memory leak in i2sbus_add_dev()
authorYang Yingliang <yangyingliang@huawei.com>
Thu, 27 Oct 2022 01:34:38 +0000 (09:34 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 3 Nov 2022 14:56:56 +0000 (23:56 +0900)
commitfc92b63f951ed963012ad9f84f5b6c5147e56408
treeba4017798859ed7f314334ebbf6d400fe948c0b4
parent498fa0227d4b7f5db6a9ed7efd0c62e3ee686cb0
ALSA: aoa: i2sbus: fix possible memory leak in i2sbus_add_dev()

[ Upstream commit f714c6e613faa09f9a68d30783721ee5611815e8 ]

dev_set_name() in soundbus_add_one() allocates memory for name, it need be
freed when of_device_register() fails, call soundbus_dev_put() to give up
the reference that hold in device_initialize(), so that it can be freed in
kobject_cleanup() when the refcount hit to 0. And other resources are also
freed in i2sbus_release_dev(), so it can return 0 directly.

Fixes: 3f4ff7c5f2ad ("[ALSA] snd-aoa: add snd-aoa")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Link: https://lore.kernel.org/r/20221027013438.991920-1-yangyingliang@huawei.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
sound/aoa/soundbus/i2sbus/core.c