]> git.baikalelectronics.ru Git - kernel.git/commit
mt76: fix tx status related use-after-free race on station removal
authorFelix Fietkau <nbd@nbd.name>
Sat, 23 Apr 2022 05:01:18 +0000 (07:01 +0200)
committerFelix Fietkau <nbd@nbd.name>
Fri, 13 May 2022 07:39:35 +0000 (09:39 +0200)
commitfc8b1f705a6d97f6af045cb9be7082f6faefc41f
tree46ea12fc53c24ea4b7ae07eeca9436df99edaa77
parentc38122824f8a7b255974f655a2ceddfabd7361ab
mt76: fix tx status related use-after-free race on station removal

There is a small race window where ongoing tx activity can lead to a skb
getting added to the status tracking idr after that idr has already been
cleaned up, which will keep the wcid linked in the status poll list.
Fix this by only adding status skbs if the wcid pointer is still assigned
in dev->wcid, which gets cleared early by mt76_sta_pre_rcu_remove

Fixes: 40c11e40a81f ("mt76: introduce packet_id idr")
Tested-by: Ben Greear <greearb@candelatech.com>
Signed-off-by: Felix Fietkau <nbd@nbd.name>
drivers/net/wireless/mediatek/mt76/mac80211.c
drivers/net/wireless/mediatek/mt76/tx.c