]> git.baikalelectronics.ru Git - kernel.git/commit
loop: Fix occasional uevent drop
authorPetr Vorel <pvorel@suse.cz>
Thu, 12 Nov 2020 16:50:05 +0000 (17:50 +0100)
committerJens Axboe <axboe@kernel.dk>
Thu, 12 Nov 2020 20:59:04 +0000 (13:59 -0700)
commitfc7a57ec15eeab29bcb3603a7340af300829ab03
treec0400539b57e94605378866bddd937385453690f
parent211e7b3b40f82151163fa23c2aa3254b2fdf1dd0
loop: Fix occasional uevent drop

Commit b14c5f4fb2a3 ("loop: Switch to set_capacity_revalidate_and_notify")
causes an occasional drop of loop device uevent, which are no longer
triggered in loop_set_size() but in a different part of code.

Bug is reproducible with LTP test uevent01 [1]:

i=0; while true; do
    i=$((i+1)); echo "== $i =="
    lsmod |grep -q loop && rmmod -f loop
    ./uevent01 || break
done

Put back triggering through code called in loop_set_size().

Fix required to add yet another parameter to
set_capacity_revalidate_and_notify().

[1] https://github.com/linux-test-project/ltp/blob/master/testcases/kernel/uevents/uevent01.c

[hch: rebased on a different change to the prototype of
 set_capacity_revalidate_and_notify]

Cc: stable@vger.kernel.org # v5.9
Fixes: b14c5f4fb2a3 ("loop: Switch to set_capacity_revalidate_and_notify")
Reported-by: <ltp@lists.linux.it>
Signed-off-by: Petr Vorel <pvorel@suse.cz>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/block/loop.c