]> git.baikalelectronics.ru Git - kernel.git/commit
net: Fix unwanted sign extension in netdev_stats_to_stats64()
authorFelix Riemann <felix.riemann@sma.de>
Fri, 10 Feb 2023 12:36:44 +0000 (13:36 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 22 Feb 2023 11:59:50 +0000 (12:59 +0100)
commitfc514a7f87a67d6445d627be45ac42d63b9ccb0b
tree931997cc3751e0cb8c696ce5b1171b23eaf550c6
parent653df7e5a4644754cd2e57945a2cbb7248f2f49d
net: Fix unwanted sign extension in netdev_stats_to_stats64()

commit 49aec574d25faf87af53b3c4dadd15f76e04bec2 upstream.

When converting net_device_stats to rtnl_link_stats64 sign extension
is triggered on ILP32 machines as e867796457 changed the previous
"ulong -> u64" conversion to "long -> u64" by accessing the
net_device_stats fields through a (signed) atomic_long_t.

This causes for example the received bytes counter to jump to 16EiB after
having received 2^31 bytes. Casting the atomic value to "unsigned long"
beforehand converting it into u64 avoids this.

Fixes: e8677964572b ("net: add atomic_long_t to net_device_stats fields")
Signed-off-by: Felix Riemann <felix.riemann@sma.de>
Reviewed-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/core/dev.c