]> git.baikalelectronics.ru Git - kernel.git/commit
kernel/sched/psi.c: simplify cgroup_move_task()
authorOlof Johansson <olof@lixom.net>
Fri, 16 Nov 2018 23:08:00 +0000 (15:08 -0800)
committerLinus Torvalds <torvalds@linux-foundation.org>
Sun, 18 Nov 2018 18:15:09 +0000 (10:15 -0800)
commitfbe01067f182d6ed98953d5c1a935f043a958554
tree06c7bc21a364b96c44f27345fc64b4da91b19e41
parent6f8e8995454d99786cdcce786a91d2ceff456bfe
kernel/sched/psi.c: simplify cgroup_move_task()

The existing code triggered an invalid warning about 'rq' possibly being
used uninitialized.  Instead of doing the silly warning suppression by
initializa it to NULL, refactor the code to bail out early instead.

Warning was:

  kernel/sched/psi.c: In function `cgroup_move_task':
  kernel/sched/psi.c:639:13: warning: `rq' may be used uninitialized in this function [-Wmaybe-uninitialized]

Link: http://lkml.kernel.org/r/20181103183339.8669-1-olof@lixom.net
Fixes: 44083edf138ee ("psi: cgroup support")
Signed-off-by: Olof Johansson <olof@lixom.net>
Reviewed-by: Andrew Morton <akpm@linux-foundation.org>
Acked-by: Johannes Weiner <hannes@cmpxchg.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
kernel/sched/psi.c