]> git.baikalelectronics.ru Git - kernel.git/commit
NFS: Fix the initialisation of the readdir 'cookieverf' array
authorTrond Myklebust <Trond.Myklebust@netapp.com>
Mon, 3 Sep 2012 18:56:02 +0000 (14:56 -0400)
committerTrond Myklebust <Trond.Myklebust@netapp.com>
Tue, 4 Sep 2012 18:52:42 +0000 (14:52 -0400)
commitfbccc207b55fadd96e17dd9a00e1babeaf1b79b0
treec042675337569f9dda0415cd4cb3e54b885bc6a0
parent79b3d564a1bb18af75f2ad3d15acbfc49ac2471f
NFS: Fix the initialisation of the readdir 'cookieverf' array

When the NFS_COOKIEVERF helper macro was converted into a static
inline function in commit c36151a2ec (nfs: convert NFS_*(inode)
helpers to static inline), we broke the initialisation of the
readdir cookies, since that depended on doing a memset with an
argument of 'sizeof(NFS_COOKIEVERF(inode))' which therefore
changed from sizeof(be32 cookieverf[2]) to sizeof(be32 *).

At this point, NFS_COOKIEVERF seems to be more of an obfuscation
than a helper, so the best thing would be to just get rid of it.

Also see: https://bugzilla.kernel.org/show_bug.cgi?id=46881

Reported-by: Andi Kleen <andi@firstfloor.org>
Reported-by: David Binderman <dcb314@hotmail.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
Cc: stable@vger.kernel.org
fs/nfs/inode.c
fs/nfs/nfs3proc.c
fs/nfs/nfs4proc.c
include/linux/nfs_fs.h