]> git.baikalelectronics.ru Git - kernel.git/commit
soc: ixp4xx/qmgr: fix invalid __iomem access
authorArnd Bergmann <arnd@arndb.de>
Tue, 3 Aug 2021 08:12:34 +0000 (10:12 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 12 Aug 2021 11:21:04 +0000 (13:21 +0200)
commitfb31e87f9678c17cf57af48e76980d3353b3e752
tree6442adad4e9507d16521e06a0f3c4e5f4ed08ebe
parent90627df66e242fda1eb7e2fa7da860b4fe04ecc2
soc: ixp4xx/qmgr: fix invalid __iomem access

commit a8eee86317f11e97990d755d4615c1c0db203d08 upstream.

Sparse reports a compile time warning when dereferencing an
__iomem pointer:

drivers/soc/ixp4xx/ixp4xx-qmgr.c:149:37: warning: dereference of noderef expression
drivers/soc/ixp4xx/ixp4xx-qmgr.c:153:40: warning: dereference of noderef expression
drivers/soc/ixp4xx/ixp4xx-qmgr.c:154:40: warning: dereference of noderef expression
drivers/soc/ixp4xx/ixp4xx-qmgr.c:174:38: warning: dereference of noderef expression
drivers/soc/ixp4xx/ixp4xx-qmgr.c:174:44: warning: dereference of noderef expression

Use __raw_readl() here for consistency with the rest of the file.
This should really get converted to some proper accessor, as the
__raw functions are not meant to be used in drivers, but the driver
has used these since the start, so for the moment, let's only fix
the warning.

Reported-by: kernel test robot <lkp@intel.com>
Fixes: 1f7a4cac5325 ("IXP42x: Add QMgr support for IXP425 rev. A0 processors.")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/soc/ixp4xx/ixp4xx-qmgr.c