]> git.baikalelectronics.ru Git - kernel.git/commit
net: aquantia: linkstate irq should be oneshot
authorIgor Russkikh <Igor.Russkikh@aquantia.com>
Fri, 30 Aug 2019 12:08:36 +0000 (12:08 +0000)
committerDavid S. Miller <davem@davemloft.net>
Sun, 1 Sep 2019 02:07:11 +0000 (19:07 -0700)
commitfb189cea127f7be2831a168eb3e510b9535bbcee
tree3e44969787c51266a3a6450060b8d108488dd76a
parent879ed309b587527cda5b24731001b46a24af6bda
net: aquantia: linkstate irq should be oneshot

Declaring threaded irq handler should also indicate the irq is
oneshot. It is oneshot indeed, because HW implements irq automasking
on trigger.

Not declaring this causes some kernel configurations to fail
on interface up, because request_threaded_irq returned an err code.

The issue was originally hidden on normal x86_64 configuration with
latest kernel, because depending on interrupt controller, irq driver
added ONESHOT flag on its own.

Issue was observed on older kernels (4.14) where no such logic exists.

Fixes: ccf377d0059c ("net: aquantia: link status irq handling")
Signed-off-by: Igor Russkikh <igor.russkikh@aquantia.com>
Reported-by: Michael Symolkin <Michael.Symolkin@aquantia.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/aquantia/atlantic/aq_nic.c