]> git.baikalelectronics.ru Git - kernel.git/commit
fpga: stratix10-soc: fix use-after-free on s10_init()
authorWen Yang <wen.yang99@zte.com.cn>
Thu, 9 May 2019 21:08:26 +0000 (16:08 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 24 May 2019 18:32:12 +0000 (20:32 +0200)
commitfad7c61f4068be27083cd8284d2b7d6d91b0f631
treeb1fc2e5f2a388c40275d4e853a510a504308805e
parent488cde845f1c95482e506ce0f8582b4b1f8cd807
fpga: stratix10-soc: fix use-after-free on s10_init()

The refcount of fw_np has already been decreased by of_find_matching_node()
so it shouldn't be used anymore.
This patch adds an of_node_get() before of_find_matching_node() to avoid
the use-after-free problem.

Fixes: 0bd2d81a520e ("fpga: add intel stratix10 soc fpga manager driver")
Signed-off-by: Wen Yang <wen.yang99@zte.com.cn>
Cc: Alan Tull <atull@kernel.org>
Cc: Moritz Fischer <mdf@kernel.org>
Cc: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Cc: linux-fpga@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Reviewed-by: Moritz Fischer <mdf@kernel.org>
Reviewed-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Acked-by: Alan Tull <atull@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/fpga/stratix10-soc.c