]> git.baikalelectronics.ru Git - kernel.git/commit
cgroup: Add missing cpus_read_lock() to cgroup_attach_task_all()
authorTetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Thu, 25 Aug 2022 08:38:38 +0000 (17:38 +0900)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 28 Sep 2022 09:03:59 +0000 (11:03 +0200)
commitfa94b4ab659fd3116a779457cb0724f7ae5ad9fe
tree9df729ec8b7626cc23a8c9d46bbb1a687dcf3fba
parent4ca055e89189aefc166b67ea44f08222354add23
cgroup: Add missing cpus_read_lock() to cgroup_attach_task_all()

commit d1e2d74f2ee89a371358695f9f4eeeeeb40a2745 upstream.

syzbot is hitting percpu_rwsem_assert_held(&cpu_hotplug_lock) warning at
cpuset_attach() [1], for commit c816169ad60e4e64 ("cgroup: Fix
threadgroup_rwsem <-> cpus_read_lock() deadlock") missed that
cpuset_attach() is also called from cgroup_attach_task_all().
Add cpus_read_lock() like what cgroup_procs_write_start() does.

Link: https://syzkaller.appspot.com/bug?extid=29d3a3b4d86c8136ad9e
Reported-by: syzbot <syzbot+29d3a3b4d86c8136ad9e@syzkaller.appspotmail.com>
Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Fixes: c816169ad60e4e64 ("cgroup: Fix threadgroup_rwsem <-> cpus_read_lock() deadlock")
Signed-off-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
kernel/cgroup/cgroup-v1.c