]> git.baikalelectronics.ru Git - kernel.git/commit
checkpatch: add fix option for LOGICAL_CONTINUATIONS
authorAditya Srivastava <yashsri421@gmail.com>
Wed, 16 Dec 2020 04:45:09 +0000 (20:45 -0800)
committerLinus Torvalds <torvalds@linux-foundation.org>
Wed, 16 Dec 2020 06:46:17 +0000 (22:46 -0800)
commitfa62cb9fb08b2fcbe945ea80a9aca7ffffe45f02
tree720282883ddb2f6b1b55d1410601186cc9e4e1fc
parentb5da0bfdaa3e28b4aaebf7dbdbdf06b1f11a8b56
checkpatch: add fix option for LOGICAL_CONTINUATIONS

Currently, checkpatch warns if logical continuations are placed at the
start of a line and not at the end of previous line.

E.g., running checkpatch on commit da2b44e9105a ("staging: bcm2835-camera:
Reduce length of enum names") reports:

  CHECK:LOGICAL_CONTINUATIONS: Logical continuations should be on the previous line
  + if (!ret
  +     && camera_port ==

Provide a simple fix by inserting logical operator at the last
non-comment, non-whitespace char of the previous line and removing from
current line, if both the lines are additions(ie start with '+')

Link: https://lkml.kernel.org/r/20201123102818.24364-1-yashsri421@gmail.com
Signed-off-by: Aditya Srivastava <yashsri421@gmail.com>
Acked-by: Joe Perches <joe@perches.com>
Cc: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
scripts/checkpatch.pl