]> git.baikalelectronics.ru Git - kernel.git/commit
usb: host: ehci-tegra: Correct teardown order of driver's removal
authorDmitry Osipenko <digetx@gmail.com>
Mon, 6 Jan 2020 01:33:58 +0000 (04:33 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 9 Jan 2020 10:15:31 +0000 (11:15 +0100)
commitfa38385ddd54d1df745368d3e80131442703af8c
tree0d3a8155a79363513b9b3c69a5560f82be30fb33
parent80ac1f97704dddbeb7a6b98e88774b2b562013df
usb: host: ehci-tegra: Correct teardown order of driver's removal

I found that PHY's enable refcounting was broken and after fixing it
I also found that machine started to hang after EHCI driver module
removal. Turned out that the teardown order is incorrect because HCD must
be unregistered *before* PHY's disabling. Note that it is also not correct
to assert the shared reset during of driver's removal because PHY takes
care of resetting shared pads and thus it's better to remove that part
from the EHCI driver.

Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
Acked-by: Alan Stern <stern@rowland.harvard.edu>
Link: https://lore.kernel.org/r/20200106013416.9604-3-digetx@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/host/ehci-tegra.c