]> git.baikalelectronics.ru Git - kernel.git/commit
ALSA: ac97: Use snd_ctl_rename() to rename a control
authorMaciej S. Szmigiero <maciej.szmigiero@oracle.com>
Thu, 20 Oct 2022 20:46:26 +0000 (22:46 +0200)
committerTakashi Iwai <tiwai@suse.de>
Fri, 21 Oct 2022 06:17:11 +0000 (08:17 +0200)
commitf9ca95d6e4a19beb6606c15da7e72b219a3d75a3
tree640591ba328fcab4c03075f6b88d79f2a180bbc7
parentc4fb51cd0be8cdf1ff18211a7958008015667866
ALSA: ac97: Use snd_ctl_rename() to rename a control

With the recent addition of hashed controls lookup it's not enough to just
update the control name field, the hash entries for the modified control
have to be updated too.

snd_ctl_rename() takes care of that, so use it instead of directly
modifying the control name.

While we are at it, check also that the new control name doesn't
accidentally overwrite the available buffer space.

Fixes: 335b14d07638 ("ALSA: control: Use xarray for faster lookups")
Cc: stable@vger.kernel.org
Signed-off-by: Maciej S. Szmigiero <maciej.szmigiero@oracle.com>
Link: https://lore.kernel.org/r/adb68bfa0885ba4a2583794b828f8e20d23f67c7.1666296963.git.maciej.szmigiero@oracle.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pci/ac97/ac97_codec.c