]> git.baikalelectronics.ru Git - kernel.git/commit
vxge: ensure data0 is initialized in when fetching firmware version information
authorColin Ian King <colin.king@canonical.com>
Tue, 18 Dec 2018 15:19:47 +0000 (15:19 +0000)
committerDavid S. Miller <davem@davemloft.net>
Wed, 19 Dec 2018 06:00:40 +0000 (22:00 -0800)
commitf9c10cd4fd878b00c634b9816eac6138ceda9c16
treedf1a5353f56e2473fee03344fa10499a8b218dad
parent9525f014833004d8749056ce5d83388374c4ce0f
vxge: ensure data0 is initialized in when fetching firmware version information

Currently variable data0 is not being initialized so a garbage value is
being passed to vxge_hw_vpath_fw_api and this value is being written to
the rts_access_steer_data0 register.  There are other occurrances where
data0 is being initialized to zero (e.g. in function
vxge_hw_upgrade_read_version) so I think it makes sense to ensure data0
is initialized likewise to 0.

Detected by CoverityScan, CID#140696 ("Uninitialized scalar variable")

Fixes: c67d514c8b31 ("vxge: serialize access to steering control register")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/neterion/vxge/vxge-config.c