]> git.baikalelectronics.ru Git - kernel.git/commit
net: stmmac: make "snps,reset-delays-us" optional again
authorMartin Blumenstingl <martin.blumenstingl@googlemail.com>
Mon, 1 Jul 2019 22:42:25 +0000 (00:42 +0200)
committerDavid S. Miller <davem@davemloft.net>
Tue, 2 Jul 2019 22:23:43 +0000 (15:23 -0700)
commitf99c181fae4c7b96315e6d7f4e0c0be54ba53a46
treee79413715bfa58c8fb5406c50ae265a387f6f255
parent4df73fb58de5ff7259bb8f88a98cfc078a114498
net: stmmac: make "snps,reset-delays-us" optional again

Commit e11b5af99ba092 ("net: stmmac: add sanity check to
device_property_read_u32_array call") introduced error checking of the
device_property_read_u32_array() call in stmmac_mdio_reset().
This results in the following error when the "snps,reset-delays-us"
property is not defined in devicetree:
  invalid property snps,reset-delays-us

This sanity check made sense until commit 8f0bc84732c3db ("net: stmmac:
initialize the reset delay array") ensured that there are fallback
values for the reset delay if the "snps,reset-delays-us" property is
absent. That was at the cost of making that property mandatory though.

Drop the sanity check for device_property_read_u32_array() and thus make
the "snps,reset-delays-us" property optional again (avoiding the error
message while loading the stmmac driver with a .dtb where the property
is absent).

Fixes: e11b5af99ba092 ("net: stmmac: add sanity check to device_property_read_u32_array call")
Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c