]> git.baikalelectronics.ru Git - kernel.git/commit
ALSA: dice: fix regression for Lexicon I-ONIX FW810S
authorTakashi Sakamoto <o-takashi@sakamocchi.jp>
Wed, 30 Nov 2022 13:06:04 +0000 (22:06 +0900)
committerTakashi Iwai <tiwai@suse.de>
Wed, 30 Nov 2022 15:15:02 +0000 (16:15 +0100)
commitf9812c119b774d74ce2e171b4daf7cd674dc1e8e
treed8423647951c3ef2509560c6ca818156aaa27b8b
parent9a79437ef5567e5f6dc1b8b17a5a7b5589dfdc55
ALSA: dice: fix regression for Lexicon I-ONIX FW810S

For Lexicon I-ONIX FW810S, the call of ioctl(2) with
SNDRV_PCM_IOCTL_HW_PARAMS can returns -ETIMEDOUT. This is a regression due
to the commit b16c453f6a8d ("ALSA: dice: wait just for
NOTIFY_CLOCK_ACCEPTED after GLOBAL_CLOCK_SELECT operation"). The device
does not emit NOTIFY_CLOCK_ACCEPTED notification when accepting
GLOBAL_CLOCK_SELECT operation with the same parameters as current ones.

This commit fixes the regression. When receiving no notification, return
-ETIMEDOUT as long as operating for any change.

Fixes: b16c453f6a8d ("ALSA: dice: wait just for NOTIFY_CLOCK_ACCEPTED after GLOBAL_CLOCK_SELECT operation")
Cc: <stable@vger.kernel.org>
Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Link: https://lore.kernel.org/r/20221130130604.29774-1-o-takashi@sakamocchi.jp
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/firewire/dice/dice-stream.c