]> git.baikalelectronics.ru Git - kernel.git/commit
ALSA: usb-audio: Drop snd_BUG_ON() from snd_usbmidi_output_open()
authorTakashi Iwai <tiwai@suse.de>
Sat, 12 Nov 2022 14:12:23 +0000 (15:12 +0100)
committerTakashi Iwai <tiwai@suse.de>
Sat, 12 Nov 2022 14:13:01 +0000 (15:13 +0100)
commitf90dcd40a01320ca1dedfe5b1a4f5a645a6c40ab
treeb2a1bd5cebd965ef8f9bfbefa561cba5eb8d0b78
parentea599da94767cc2b3f5a7db5e6bb3499291dc198
ALSA: usb-audio: Drop snd_BUG_ON() from snd_usbmidi_output_open()

snd_usbmidi_output_open() has a check of the NULL port with
snd_BUG_ON().  snd_BUG_ON() was used as this shouldn't have happened,
but in reality, the NULL port may be seen when the device gives an
invalid endpoint setup at the descriptor, hence the driver skips the
allocation.  That is, the check itself is valid and snd_BUG_ON()
should be dropped from there.  Otherwise it's confusing as if it were
a real bug, as recently syzbot stumbled on it.

Reported-by: syzbot+9abda841d636d86c41da@syzkaller.appspotmail.com
Cc: <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/syzbot+9abda841d636d86c41da@syzkaller.appspotmail.com
Link: https://lore.kernel.org/r/20221112141223.6144-1-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/usb/midi.c