]> git.baikalelectronics.ru Git - kernel.git/commit
nfc: nfcmrvl: Fix potential memory leak in nfcmrvl_i2c_nci_send()
authorShang XiaoJing <shangxiaojing@huawei.com>
Thu, 27 Oct 2022 14:03:32 +0000 (22:03 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 10 Nov 2022 16:57:50 +0000 (17:57 +0100)
commitf90b7a559ffb22c7b50db797cad2c37c7b749761
tree57c7c11daee47ce4f19a5d5dee8e9eef867eae84
parent0a1f27d38ca8bdd829a8c661cb314e29918700f9
nfc: nfcmrvl: Fix potential memory leak in nfcmrvl_i2c_nci_send()

[ Upstream commit 86899a14a3af5fd07b27d937098be1e149815cd6 ]

nfcmrvl_i2c_nci_send() will be called by nfcmrvl_nci_send(), and skb
should be freed in nfcmrvl_i2c_nci_send(). However, nfcmrvl_nci_send()
will only free skb when i2c_master_send() return >=0, which means skb
will memleak when i2c_master_send() failed. Free skb no matter whether
i2c_master_send() succeeds.

Fixes: a1db6ddfdf0e ("NFC: nfcmrvl: add i2c driver")
Signed-off-by: Shang XiaoJing <shangxiaojing@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/nfc/nfcmrvl/i2c.c