]> git.baikalelectronics.ru Git - kernel.git/commit
fs: Remove FIXME comment in generic_write_checks()
authorTal Zussman <tz2294@columbia.edu>
Fri, 31 Dec 2021 07:57:50 +0000 (02:57 -0500)
committerAl Viro <viro@zeniv.linux.org.uk>
Sun, 30 Jan 2022 19:34:55 +0000 (14:34 -0500)
commitf8a3e94aa38286900fdfaf33e3ebc9672c4ceaa6
tree14c5041e3a5a26ac1e1a7d1783b06730bc169c3f
parent991a5e519c2aa1f4ed2bf6e2139997d7e7967cb3
fs: Remove FIXME comment in generic_write_checks()

This patch removes an unnecessary comment that had to do with block special
files from `generic_write_checks()`.

The comment, originally added in Linux v2.4.14.9, was to clarify that we only
set `pos` to the file size when the file was opened with `O_APPEND` if the file
wasn't a block special file. Prior to Linux v2.4, block special files had a
different `write()` function which was unified into a generic `write()` function
in Linux v2.4. This generic `write()` function called `generic_write_checks()`.
For more details, see this earlier conversation:
https://lore.kernel.org/linux-fsdevel/Yc4Czk5A+p5p2Y4W@mit.edu/

Currently, block special devices have their own `write_iter()` function and no
longer share the same `generic_write_checks()`, therefore rendering the comment
irrelevant.

Signed-off-by: Tal Zussman <tz2294@columbia.edu>
Co-authored-by: Xijiao Li <xl2950@columbia.edu>
Co-authored-by: Hans Montero <hjm2133@columbia.edu>
Suggested-by: Theodore Ts'o <tytso@mit.edu>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
fs/read_write.c