]> git.baikalelectronics.ru Git - kernel.git/commit
ASoC: tas2780: Fix set_tdm_slot in case of single slot
authorMartin Povišer <povik+lin@cutebit.org>
Thu, 27 Oct 2022 09:58:00 +0000 (11:58 +0200)
committerMark Brown <broonie@kernel.org>
Mon, 31 Oct 2022 13:20:01 +0000 (13:20 +0000)
commitf83f186dbb52fa522ab2e30d267cc3c5cf53771f
tree1ce227ae8e095041d3250cfc212ee6b23547f8a4
parentf0baf1e205a71c0ed1e55f4a13ffdc2ba7cf8a6f
ASoC: tas2780: Fix set_tdm_slot in case of single slot

There's a special branch in the set_tdm_slot op for the case of nslots
being 1, but:

 (1) That branch can never work (there's a check for tx_mask being
     non-zero, later there's another check for it *being* zero; one or
     the other always throws -EINVAL).

 (2) The intention of the branch seems to be what the general other
     branch reduces to in case of nslots being 1.

For those reasons remove the 'nslots being 1' special case.

Fixes: 0e557b9457ac ("ASoC: add tas2780 driver")
Suggested-by: Jos Dehaes <jos.dehaes@gmail.com>
Signed-off-by: Martin Povišer <povik+lin@cutebit.org>
Link: https://lore.kernel.org/r/20221027095800.16094-3-povik+lin@cutebit.org
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/tas2780.c