]> git.baikalelectronics.ru Git - kernel.git/commit
usb: misc: fix improper handling of refcount in uss720_probe()
authorHangyu Hua <hbh25y@gmail.com>
Thu, 7 Apr 2022 02:40:01 +0000 (10:40 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 21 Apr 2022 16:57:31 +0000 (18:57 +0200)
commitf83c3f966f003f796b5a1475991f03f2267a7c03
treeafd287d3cc9164261e5bd579b5e0b4d5f14f4b0b
parent640c4af109f76b69b6efa5eb7bbdedfe4b174057
usb: misc: fix improper handling of refcount in uss720_probe()

usb_put_dev shouldn't be called when uss720_probe succeeds because of
priv->usbdev. At the same time, priv->usbdev shouldn't be set to NULL
before destroy_priv in uss720_disconnect because usb_put_dev is in
destroy_priv.

Fix this by moving priv->usbdev = NULL after usb_put_dev.

Fixes: 240c4bc5c11a ("misc/uss720: fix memory leak in uss720_probe")
Cc: stable <stable@kernel.org>
Reviewed-by: Dongliang Mu <mudongliangabcd@gmail.com>
Signed-off-by: Hangyu Hua <hbh25y@gmail.com>
Link: https://lore.kernel.org/r/20220407024001.11761-1-hbh25y@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/misc/uss720.c