]> git.baikalelectronics.ru Git - kernel.git/commit
drm/i915: Do fbdev fini first during unload
authorVille Syrjälä <ville.syrjala@linux.intel.com>
Fri, 6 Nov 2015 13:08:32 +0000 (15:08 +0200)
committerVille Syrjälä <ville.syrjala@linux.intel.com>
Wed, 11 Nov 2015 11:34:47 +0000 (13:34 +0200)
commitf83170da807a99d4c1056a1a7e3df05de498d0f0
tree7d732e928bb4fbc36fb208b2120b6798fc3b8572
parent614f70e9ed67866221f65586ad82c70d16e0fec5
drm/i915: Do fbdev fini first during unload

We set up fbdev last during load, so doing the fbdev cleanup should be
first.

We weren't supposed to drop the init power during driver unload, but since
the fbdev teardown happened after intel_power_domains_fini() that could
have happened due in one of two ways. First it could have happened
during the modeset caused by normal fbdev cleanup. But in addition it
could have happened already via the intel_fbdev_initial_config() since
that is executed asynhronously, and the async_synchronize_full() was
done during fbdev cleanup, after intel_power_domains_fini(). All of
that got eliminated by
commit 3476772c617fc ("drm/i915: Update power domains on readout.")
since we now drop the init power synchronously during driver load.

So there is no real bug wrt. the init power anymore, but still it seems
better to do the fbdev cleanup first, before we've potentially cleaned
up something else important.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/1446815313-9490-3-git-send-email-ville.syrjala@linux.intel.com
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
drivers/gpu/drm/i915/i915_dma.c